[Solved] Pdex bug (loss of user funds after a trade)

Okay, thanks ducky. I got one txn returned, still waiting on the other. kinda want to go through my list of trades today and make sure everything adds up. Ill keep you posted

2 Likes

The txn returned so far is the 0.145147255 pBTC . still waiting on the 16970.21037 pUSDT, but I know you guys are working on it)

Got the usdt back. ty for the help. hope whatever caused this is fixed cause I am a bit nervous trading now heh.

This actually was not a UI bug, the transactions were never delievered post trade to my wallet. Confirmed over rpc calls w/ fullnode ; the transactions are logged in the network explorer being sent to me as the dev team “corrected it”

1 Like

Hey guys! To follow up on this issue.

Some pDEX trades were rejected. Causing subsequent trades to also be rejected. A few users experienced funds not returned after an unsuccessful trade. Our devs have pushed a fix through new code which will auto-retry your trade after it was rejected so you will no longer experience unsuccessful trades where funds are not returned. Instead, the trade will be retried a few moment later.

-Hope that helps clear it up a bit.

4 Likes

My 2 trades as documented in the network explorer links above did not fail. They returned trade accepted. Whatever ever function of the pdex that sends the user the funds post trade, did not work. I tried locating the code for this in the pdex, as me and @Revolve were discussing (in the discord community) the inner mechanics of a trade in respect to roundtrip between user wallet back to user wallet (including all the state changes) So whatever bug the devs think they fixed might not apply to my scenario.

If im missing the code somewhere , could someone point it out for me? For instance, where did my pcoins go when they did not get returned to me? Is there a pool that holds trade swap coins during a trade? if so, who has access to this pool? ----> is it in fact decentralized like the original concept engine built for uniswap?

@duc

@Chucky

2 Likes

hey @Matt6412, please look into the post to see how it works right now and what we will be able to improve with one-time address: One-Time Address - Improve on privacy and pDEX performance
If you have any further questions or concerns, feel free to leave comments here, love to have a conversation with you as always.

3 Likes

Hi guys, I think it is happening again. I have traded at 3 am GMT using sdk. Trade was submitted with success but wallet shows no funds now. I restarted the program and my log file was overwrited, so what can I do ?

Hi @Peter, I posted here as you have asked on telegram.

Thank you,

1 Like

hi, @pfrp should you give us your tx trade ?

Hi binh, the funds was not showing using js sdk, but using incognito app the funds was there. Is it possible to read past transactions using the sdk if I did not save them localy ?

1 Like

Hi @binh, it happened again. Today I have traded using Incognito App and the trade took to long and was unsuccessful, but funds did not come back. Trade ID: 60322 at 08 mar 2021 12:02 PM.

Can you help me ?
Thank you

@pfrp
1.

Hi binh, the funds was not showing using js sdk, but using incognito app the funds was there. Is it possible to read past transactions using the sdk if I did not save them localy ?

For this, because ‘send’ records are stored locally,
it’s impossible to read ‘send’ history if you don’t send via wallet.

For trade got lost: please wait a bit more patiently, we will double check.
Sorry for this inconvenient experience!

So this bug is still not fixed it seems. Also my bug resulted in funds not being returned after 2 successful trades and no report was made saying saying solution was found (cause of bug and fix, obviously the devs manually returned my money since I provided proper citation of trades).

With both of these being said, why would any user dare risk using this app to trade until this massive bug / bugs are fixed ?

Hi @binh, the funds are back. Thank you. Does the team have an estimated date to fix this bug ?

we will release a hotfix to improve and fix this issue in next week.
Please wait.
Thanks alot.

1 Like

Hey @Matt6412, pDEX does not have such a risk. The chain works well. So funds are SAFU. The problem is about the app (client side). In other words, the funds are in the user’s wallet but the app cannot show them correctly.

3 Likes

This is not correct in my case. I checked my funds via rpc utilizing the read only key and checked my wallet balances, the funds from the trade never were delivered.

Also a separate transaction dated after I alerted the team and they started responding to the incident was marked when they “pushed the button” to “give me back my money from the successful trade”

2 Likes

Hi guys,
we had released a hotfix to improve not refund trade issue, and fix network is a little busy

have a good weekend and hope you have a better experience.

2 Likes

Hey @Matt6412 and others who experienced this issue (or even other issues),

Firstly, I wanna say sorry to you guys for the very bad experience you encountered with Incognito product.

Secondly, I personally think that it’s not fair enough for you guys if the core devs team only says “the issue got fixed” and didn’t give any explanation about:

  • what is the current process/flow? why does it look centralized with temporary addresses?
  • why did funds get stuck? what were the root causes?
  • what are the core devs team’s solutions to address those problems in both short term and long term?

It’s all about transparency and in my opinion, transparency is a must to gain (or regain) trust from Incognito users. Please bear with me, I’ll be making a post to answer to above questions early next week and following up on further discussion if any.

Also, the core devs team has also been working on a new roadmap that will likely focus on fundamental things such as decentralization (both network and app), network stability, and security.

7 Likes

Thank you @duc for the apology to the @Matt6412 and the others you express in your post…but indeed make sure to follow up with that post you speak about making next week for indeed the integrity of the project, and yourself for that matter, is being questioned and the last thing you do not wish to do is leave the guys hanging about that forthcoming post…it would not be a good idea… :sunglasses:

2 Likes