[Shipped] Internal Code Audit

[thaibao]

Objective:

Review total internal code base of incognito chain

Length:

1 month

Key results:

• Perform peer to peer code review for all teams.
• Process is simply put:

1/ Review spec
2/ Review code vs spec
3/ Enough unit tests
4/ Review test cases

Detail Schedule:

Please refer to this sheet.

[hungngo]

Update 11 Aug 2020

Block reward for Validator, DAO
Finish:

1. Review spec
2. Review code vs spec
3. Unit-test cover most of pure logic function, some complex functions will be tested via integration test
4. More integration testcases with QC team

In progress:

1. Integration test by QC team

[thaibao]

Merged unittest of " Block reward for Validator, DAO" into main branch

[thaibao]

Completed internal code audit and merged more unittest for 2 version of PDEX

[thaibao]

About privacy ver.1, we have detected and fixed some bugs. We will deployed and double check on testnet tomorrow

[thaibao]

For a code audit of Block Reward Validator, we complete a full test case and try on testing. The result is that we don’t have any issue with this.

We also review and revise the content of Portal v2 spec. This week, we will start to review code and write fully unit test

About privacy v.1, everything is fixed on testnet and it should be released on next friday

Thanks

[duc]

Hey, I just wanted to update the progress for Portal v2 audit. We almost finish this and the following is a few key points:

• Detected issues related to big number and shielding flow. These two have been fixed.
• Written more tests in order to make it more robust.
• Learnt from similar projects to make sure Portal doesn’t repeat the same issue. (https://blog.keep.network/details-of-the-tbtc-deposit-pause-on-may-18-2020-38d7dd555663)

We’re creating a pull request for these changes today and will deploy on testnet afterward.

[thaibao]

Completed audit and deploy fixied issued on Mainnet.
For this task, we will continuously audit for staking flow and portal v2

[thaibao]

Auditing for staking flow and portal v2 is completed, we will tag the new version on next Web