Cool. I will keep my change, I think removing protocol from the GETH_NAME and set it with GETH_PROTOCOL is cleaner as long as that variable exists.
If we’re being picky…
That’s not a host, that’s a host with path.
My vote would have been to remove them all and define a GETH_URL instead. That’s basically what it all ends up as inside the
BuildRPCServerAddress function that just slaps them all together into an URL (protocol + host + port, ends up as an invalid url if you define a port and the host contains a path btw).
protocol://host:port/path, something that everyone understands, leaves no room for conflicting parameters, and the net/http package already handles it correctly (defaults to port 443 for https etc.)
your default would then be
and cause no problems for someone that wants to run “http://localhost:1234” or whatever.